It is a problem only in the context of making work and social life difficult- it doesn't do any direct physical or mental damage
Yes, they don't do direct physical or mental damage the same way not having an arm doesn't deal direct physical or mental damage. THEY ARE THE DAMAGE.
As you rightly point out, this damage causes people lots of problems.
and although there may be genetics underpinning it, this is nothing that can't be explained by natural variation.
You could say the same about genetic disorders, which are definitely caused by "natural variation." I don't see why that's an excuse to not treat something. Nature's a nasty piece of work, and there's no reason to respect something because it is "natural."
As you point out above, these problems, which ARE damage, inflict further damage on someone's life. Why shouldn't they be treated?
Up to 10% of children in the US apparently have it now even though it only gained wide acceptance as a medical condition in the 70s, although drugs were used before this to treat hyperactivity and a similar set of 'symptoms' have been called by various other names since the 1900s. The diagnostic methods used are arbitrary. The fact that stimulants work doesn't lend ADHD any credibility - smoking helps me concentrate, does this mean I have ADHD ?
These are disorders. They are damage or malfunctioning of some sort. You admit they cause disruption and unhappiness in life. If a particular treatment alleviates this problem whereas a placebo or other treatment does not, how can you conclude treatments don't matter?
You could make the same argument about how physics is meaningless and is just making crap. This would especially be true if you looked in the first hundred years or so of physics development. Psychology is an EXTREMELY young science, so naturally there has been a lot of upheaval and work in the past 100 years. Heck, for a significant portion of that time running experiments wasn't even done by a lot of people in the field. It's of course a tricky subject, but we're doing pretty well now in terms of experimental design and testing.
I don't know why ADHD has a bee in your bonnet so much, but it is real. There's been a lot of research into it and into what part of the brain it affects, how it affects thinking, etc, etc. While it isn't precisely understood, it is understood that people with ADHD have a great deal of difficulty focusing on tasks, making and executing plans, etc, etc. Far more so than the average person. Secondary symptoms vary. Do you have some evidence that it is defined arbitrarily?
While diagnostic tests vary, it isn't like they aren't looking at something specific. The definition in the DSM-IV is as precise as that for depression, PTSD, or any of a number of other disorders.
Similarly for dyslexia. It is precisely defined. It is not the cause of all reading problems. It has particular treatments that work well for it.
Smoking doesn't have a significant stimulant. If it helps you concentrate, it is most likely because you are addicted to nicotine and need a fix. That has different symptoms and causes, even if there are at times some overlap. Addiction is also covered in the DSM-IV.