Legal in New York, and sensible when dealing with Trump. After all, if the conversations were privileged attorney-client conversations and legal, the evidence wouldn't be admissible.
Where specifically? Illegal instructions are not privileged.
Cohen was within his rights to reach a plea deal concerning his illegal activities, including those illegal activities that involved Trump
And again, you are asserting he breached attorney-client privilege, but haven't given an example of a privileged conversation that he has disclosed. Given Cohen's general level of legal competence, I would be unsurprised if he did, but am unaware of any examples.
I said that I can accept the hypothetical situation where Trump asked Cohen for work that was not illegal.
I don't know about the indemnity clause.